Skip to content

style: improve formatting of spec file #12379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 27, 2018

style: improve formatting of spec file

style: remove redundant async in tests
In component specs only the compileComponents is async thus the async on it are redudnant

Closes #12161

In component specs only the `compileComponents` is async thus the `async` on `it` are redudnant

Closes #12161
@alan-agius4 alan-agius4 force-pushed the alan-agius4-formatting_spec branch from 13e3a54 to 4bb91cf Compare September 27, 2018 11:31
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 27, 2018
@alan-agius4 alan-agius4 deleted the alan-agius4-formatting_spec branch September 27, 2018 11:49
@alan-agius4
Copy link
Collaborator Author

Superseded by #12380

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__name@dasherize__.component.spec.ts don't use async in spec case
2 participants